Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to kubernetes guestbook app. #2605

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Add flags to kubernetes guestbook app. #2605

merged 2 commits into from
Feb 28, 2017

Conversation

thompsonja
Copy link
Contributor

This will allow users to run the app in arbitrary ports/cells (useful for sandboxes).

dumbunny
dumbunny approved these changes Feb 28, 2017
View reviewed changes
examples/kubernetes/guestbook-up.sh Outdated
echo "Creating guestbook replicationcontroller..."
$KUBECTL create --namespace=$VITESS_NAME -f guestbook-controller.yaml
cat guestbook-controller-template.yaml | sed -e "$sed_script" | $KUBECTL create --namespace=$VITESS_NAME -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat | sed = Meh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@thompsonja thompsonja merged commit 678ea9f into vitessio:master Feb 28, 2017
@thompsonja thompsonja deleted the guestbook branch February 28, 2017 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumbunny dumbunny dumbunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsonja @dumbunny @googlebot